Skip to content

Conversation

@hannesrudolph
Copy link
Collaborator

DO NOT MERGE

Summary:
Adds a fallback normalizer that translates VSCode-LM <function_calls>…</function_calls> into native … tool XML. Zero behavior change for already-correct native XML; preserves inner byte-for-byte; default ON.

Integration points:

New module:

Behavior:

  • Strip <function_calls> container
  • Map … → … only for known ToolName; unknown tools pass-through
  • Streaming path uses small tail buffer, 1MB guard, and a stack; idempotent; never mutates

Telemetry:

  • function_calls_normalized (boolean), toolNamesEncountered (set), modelId — minimal, non-PII

Tests:

Rollout:

  • Enabled by default with light telemetry; can be disabled via experiment/provider state if needed

Risks/Mitigations:

  • Mis-detection or malformed XML → rewrite only on full tokens; guarded stack; pass-through fallback

Acceptance:

  • function_calls inputs execute equivalently to native XML; args preserved; no regressions.

…ion_calls/invoke → native <tool> XML; integrate in streaming/non-stream parsers; add minimal telemetry and tests
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Oct 30, 2025
@daniel-lxs daniel-lxs moved this from Triage to PR [Draft / In Progress] in Roo Code Roadmap Oct 30, 2025
@hannesrudolph hannesrudolph added PR - Draft / In Progress and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Oct 30, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Nov 3, 2025
@github-project-automation github-project-automation bot moved this from PR [Draft / In Progress] to Done in Roo Code Roadmap Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants